fix: typo in DurableExecutionJournal.ts (#3174)

Effect-TS · Jul 13, 2024 · 42aec0e · 42aec0e
1 parent 68f9cc9
commit 42aec0e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/.changeset/thirty-pets-switch.md b/.changeset/thirty-pets-switch.md
@@ -0,0 +1,5 @@
+---
+"@effect/cluster-workflow": patch
+---
+
+fix DurableExecutionJournalTypeId type and discriminate the DurableExecutionJournal interface
diff --git a/packages/cluster-workflow/src/DurableExecutionJournal.ts b/packages/cluster-workflow/src/DurableExecutionJournal.ts
@@ -21,12 +21,13 @@ export const DurableExecutionJournalTypeId: unique symbol = Symbol.for(SymbolKey
  * @since 1.0.0
  * @category symbols
  */
-export type DurableExecutionJournalTypeId = typeof DurableExecutionJournal
+export type DurableExecutionJournalTypeId = typeof DurableExecutionJournalTypeId
 
 /**
  * @since 1.0.0
  */
 export interface DurableExecutionJournal {
+  readonly [DurableExecutionJournalTypeId]: DurableExecutionJournalTypeId
   read<A, IA, E, IE>(
     persistenceId: string,
     success: Schema.Schema<A, IA>,
@@ -158,10 +159,13 @@ export const make = ({ table }: DurableExecutionJournal.MakeOptions) =>
       )
     }
 
-    return {
+    const self: DurableExecutionJournal = {
+      [DurableExecutionJournalTypeId]: DurableExecutionJournalTypeId,
       append,
       read
-    } as const
+    }
+
+    return self
   })
 
 /**

diff --git a/packages/cluster-workflow/src/DurableExecutionJournalInMemory.ts b/packages/cluster-workflow/src/DurableExecutionJournalInMemory.ts
@@ -23,7 +23,8 @@ export const activityJournalInMemory = Layer.effect(
   DurableExecutionJournal.DurableExecutionJournal,
   Effect.gen(function*(_) {
     const memory = yield* _(Ref.make<Array<JournalEntry>>([]))
-    return ({
+    const self: DurableExecutionJournal.DurableExecutionJournal = {
+      [DurableExecutionJournal.DurableExecutionJournalTypeId]: DurableExecutionJournal.DurableExecutionJournalTypeId,
       append: (persistenceId, _, __, event) =>
         pipe(
           Ref.update(memory, (_) => _.concat([new JournalEntry({ persistenceId, event })]))
@@ -36,6 +37,7 @@ export const activityJournalInMemory = Layer.effect(
           Stream.filter((_) => _.persistenceId === persistenceId),
           Stream.map((_) => _.event)
         )
-    })
+    }
+    return self
   })
 )