Either: fix fromOption overloads order (#2194)

Effect-TS · Feb 21, 2024 · 55b26a6 · 55b26a6
1 parent 136ef40
commit 55b26a6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/mighty-horses-begin.md b/.changeset/mighty-horses-begin.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Either: fix `fromOption` overloads order
diff --git a/packages/effect/src/Either.ts b/packages/effect/src/Either.ts
@@ -142,8 +142,8 @@ export const fromNullable: {
  * @since 2.0.0
  */
 export const fromOption: {
-  <R, L>(self: Option<R>, onNone: () => L): Either<R, L>
   <L>(onNone: () => L): <R>(self: Option<R>) => Either<R, L>
+  <R, L>(self: Option<R>, onNone: () => L): Either<R, L>
 } = either.fromOption
 
 const try_: {

diff --git a/packages/effect/src/internal/either.ts b/packages/effect/src/internal/either.ts
@@ -100,7 +100,10 @@ export const getRight = <R, L>(
 ): Option<R> => (isLeft(self) ? option.none : option.some(self.right))
 
 /** @internal */
-export const fromOption = dual(
+export const fromOption: {
+  <L>(onNone: () => L): <R>(self: Option<R>) => Either.Either<R, L>
+  <R, L>(self: Option<R>, onNone: () => L): Either.Either<R, L>
+} = dual(
   2,
   <R, L>(self: Option<R>, onNone: () => L): Either.Either<R, L> =>
     option.isNone(self) ? left(onNone()) : right(self.value)