default to never for Runtime returning functions (#2096)

Effect-TS · Feb 10, 2024 · 6654f5f · 6654f5f
1 parent 2eb11b4
commit 6654f5f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/.changeset/brave-rats-travel.md b/.changeset/brave-rats-travel.md
@@ -0,0 +1,13 @@
+---
+"effect": patch
+---
+
+default to `never` for Runtime returning functions
+
+This includes:
+
+- Effect.runtime
+- FiberSet.makeRuntime
+
+It prevents `unknown` from creeping into types, as well as `never` being a
+useful default type for propogating Fiber Refs and other context.
diff --git a/packages/effect/src/Effect.ts b/packages/effect/src/Effect.ts
@@ -4536,7 +4536,7 @@ export const randomWith: <A, E, R>(f: (random: Random.Random) => Effect<A, E, R>
  * @since 2.0.0
  * @category runtime
  */
-export const runtime: <R>() => Effect<Runtime.Runtime<R>, never, R> = _runtime.runtime
+export const runtime: <R = never>() => Effect<Runtime.Runtime<R>, never, R> = _runtime.runtime
 
 /**
  * Retrieves an effect that succeeds with the current runtime flags, which

diff --git a/packages/effect/src/FiberSet.ts b/packages/effect/src/FiberSet.ts
@@ -101,7 +101,7 @@ export const make = <A = unknown, E = unknown>(): Effect.Effect<FiberSet<A, E>,
  * @since 2.0.0
  * @categories constructors
  */
-export const makeRuntime = <R, A = unknown, E = unknown>(): Effect.Effect<
+export const makeRuntime = <R = never, A = unknown, E = unknown>(): Effect.Effect<
   <XE extends E, XA extends A>(
     effect: Effect.Effect<XA, XE, R>,
     options?: Runtime.RunForkOptions | undefined