fix support for Predicates in Predicate.compose (#3000)

Effect-TS · Jun 17, 2024 · 7204ca5 · 7204ca5
1 parent 06ede85
commit 7204ca5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/tidy-pandas-juggle.md b/.changeset/tidy-pandas-juggle.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+fix support for Predicates in Predicate.compose
diff --git a/packages/effect/dtslint/Predicate.ts b/packages/effect/dtslint/Predicate.ts
@@ -225,6 +225,9 @@ Predicate.compose(Predicate.isString, (
   s // $ExpectType string
 ): s is NonEmptyString => s.length > 0)
 
+// $ExpectType Refinement<unknown, string>
+pipe(Predicate.isString, Predicate.compose((s) => /^a/.test(s)))
+
 // -------------------------------------------------------------------------------------
 // and
 // -------------------------------------------------------------------------------------

diff --git a/packages/effect/src/Predicate.ts b/packages/effect/src/Predicate.ts
@@ -631,7 +631,9 @@ export const isPromiseLike = (
  */
 export const compose: {
   <A, B extends A, C extends B>(bc: Refinement<B, C>): (ab: Refinement<A, B>) => Refinement<A, C>
+  <A, B extends A>(bc: Predicate<NoInfer<B>>): (ab: Refinement<A, B>) => Refinement<A, B>
   <A, B extends A, C extends B>(ab: Refinement<A, B>, bc: Refinement<B, C>): Refinement<A, C>
+  <A, B extends A>(ab: Refinement<A, B>, bc: Predicate<NoInfer<B>>): Refinement<A, B>
 } = dual(
   2,
   <A, B extends A, C extends B>(ab: Refinement<A, B>, bc: Refinement<B, C>): Refinement<A, C> => (a): a is C =>