-
-
Notifications
You must be signed in to change notification settings - Fork 231
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
change
STM
type parameters order from STM<R, E, A>
to `STM<A, E =…
… never, R = never>` (#2043)
- Loading branch information
Showing
48 changed files
with
2,248 additions
and
1,652 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"effect": minor | ||
--- | ||
|
||
change `STM` type parameters order from `STM<R, E, A>` to `STM<A, E = never, R = never>` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#!/bin/bash | ||
dirs=(./src) | ||
for dir in ${dirs[@]}; | ||
do | ||
echo Refactoring $dir | ||
files=$(find $dir -type f \( -name "*.ts" -o -name "*.tsx" \) | xargs ls) | ||
npx jscodeshift \ | ||
-t \ | ||
./mod.ts \ | ||
--extensions=ts,tsx \ | ||
--parser=ts \ | ||
$files | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
import type k from "ast-types/gen/kinds.js" | ||
import type cs from "jscodeshift" | ||
|
||
const enabled = { | ||
swapSTMParams: false, | ||
swapSTMGenParams: false, | ||
cleanupSTM: false, | ||
cleanupEffect: false, | ||
cleanupStream: false, | ||
cleanupExit: false | ||
} | ||
|
||
const cleanup = (nodeName: string) => (ast: cs.ASTPath<cs.TSTypeReference>) => { | ||
const name = ast.value.typeName | ||
const is = (node: typeof name): boolean => { | ||
switch (node.type) { | ||
case "Identifier": { | ||
if (node.name === nodeName) { | ||
return true | ||
} | ||
return false | ||
} | ||
case "JSXIdentifier": { | ||
return false | ||
} | ||
case "TSQualifiedName": { | ||
return is(node.right) | ||
} | ||
case "TSTypeParameter": { | ||
return false | ||
} | ||
} | ||
} | ||
if ( | ||
is(name) && | ||
ast.value.typeParameters | ||
) { | ||
const params = ast.value.typeParameters.params | ||
const len = params.length | ||
for (let i = 1; i < len; i++) { | ||
popNever(params) | ||
} | ||
} | ||
} | ||
|
||
const cleanupEffect = cleanup("Effect") | ||
const cleanupStream = cleanup("Stream") | ||
const cleanupExit = cleanup("Exit") | ||
const cleanupSTM = cleanup("STM") | ||
|
||
const swapParams = (nodeName: string) => (ast: cs.ASTPath<cs.TSTypeReference>) => { | ||
const name = ast.value.typeName | ||
const is = (node: typeof name): boolean => { | ||
switch (node.type) { | ||
case "Identifier": { | ||
if (node.name === nodeName) { | ||
return true | ||
} | ||
return false | ||
} | ||
case "JSXIdentifier": { | ||
return false | ||
} | ||
case "TSQualifiedName": { | ||
return is(node.right) | ||
} | ||
case "TSTypeParameter": { | ||
return false | ||
} | ||
} | ||
} | ||
if ( | ||
is(name) && | ||
ast.value.typeParameters && | ||
ast.value.typeParameters.params.length === 3 | ||
) { | ||
const params = ast.value.typeParameters.params | ||
const newParams = [params[2], params[1], params[0]] | ||
popNever(newParams) | ||
popNever(newParams) | ||
ast.value.typeParameters.params = newParams | ||
} | ||
} | ||
|
||
const swapSTMParams = swapParams("STM") | ||
const swapSTMGenParams = swapParams("STMGen") | ||
|
||
const popNever = (params: Array<k.TSTypeKind>) => { | ||
if (params.length > 0 && params[params.length - 1].type === "TSNeverKeyword") { | ||
params.pop() | ||
} | ||
} | ||
|
||
export default function transformer(file: cs.FileInfo, api: cs.API) { | ||
const j = api.jscodeshift | ||
const root = j(file.source) | ||
|
||
const forEveryTypeReference = (node: typeof root, f: (ast: cs.ASTPath<cs.TSTypeReference>) => void) => { | ||
node.find(j.TSTypeReference).forEach((ast) => { | ||
f(ast) | ||
}) | ||
node.find(j.CallExpression).forEach((path) => { | ||
const typeParams = (path.value as any).typeParameters as cs.TSTypeParameterInstantiation | ||
if (typeParams) { | ||
j(typeParams).find(j.TSTypeReference).forEach((tref) => { | ||
f(tref) | ||
}) | ||
} | ||
}) | ||
} | ||
|
||
forEveryTypeReference(root, (ast) => { | ||
if (enabled.swapSTMParams) { | ||
swapSTMParams(ast) | ||
} | ||
if (enabled.swapSTMGenParams) { | ||
swapSTMGenParams(ast) | ||
} | ||
if (enabled.cleanupEffect) { | ||
cleanupEffect(ast) | ||
} | ||
if (enabled.cleanupStream) { | ||
cleanupStream(ast) | ||
} | ||
if (enabled.cleanupExit) { | ||
cleanupExit(ast) | ||
} | ||
if (enabled.cleanupSTM) { | ||
cleanupSTM(ast) | ||
} | ||
}) | ||
|
||
return root.toSource() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.