reconcile if waiters

Effect-TS · May 28, 2024 · 75a0dc5 · 75a0dc5
1 parent d476d97
commit 75a0dc5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/effect/src/internal/pool.ts b/packages/effect/src/internal/pool.ts
@@ -237,7 +237,9 @@ class PoolImpl<A, E> implements Pool<A, E> {
       if (poolItem.refCount === 0) {
         this.items.delete(poolItem)
         this.invalidated.delete(poolItem)
-        return poolItem.finalizer
+        return this.waiters > 0
+          ? Effect.zipRight(poolItem.finalizer, this.reconcile)
+          : poolItem.finalizer
       }
       this.invalidated.add(poolItem)
       return Effect.void

diff --git a/packages/effect/test/KeyedPool.test.ts b/packages/effect/test/KeyedPool.test.ts
@@ -57,8 +57,9 @@ describe("KeyedPool", () => {
           () =>
             Effect.scoped(pipe(
               KeyedPool.get(pool, "key1"),
-              Effect.flatMap((value) =>
-                Effect.zipRight(
+              Effect.flatMap((value) => {
+                console.log("get", value)
+                return Effect.zipRight(
                   Effect.whenEffect(
                     KeyedPool.invalidate(pool, value),
                     Random.nextBoolean
@@ -68,7 +69,7 @@ describe("KeyedPool", () => {
                     (n) => Effect.sleep(Duration.millis(n))
                   )
                 )
-              )
+              })
             )),
           { concurrency: "unbounded", discard: true }
         )