Optimize Array.sortWith to avoid calling the map function excesively (#…

…3536)
Effect-TS · Sep 2, 2024 · 79859e7 · 79859e7
1 parent ab8729d
commit 79859e7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/clean-meals-pull.md b/.changeset/clean-meals-pull.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Optimize Array.sortWith to avoid calling the map function excesively
diff --git a/packages/effect/src/Array.ts b/packages/effect/src/Array.ts
@@ -1255,7 +1255,8 @@ export const sortWith: {
   <A, B>(self: Iterable<A>, f: (a: A) => B, order: Order.Order<B>): Array<A>
 } = dual(
   3,
-  <A, B>(self: Iterable<A>, f: (a: A) => B, order: Order.Order<B>): Array<A> => sort(self, Order.mapInput(order, f))
+  <A, B>(self: Iterable<A>, f: (a: A) => B, order: Order.Order<B>): Array<A> =>
+    Array.from(self).map((a) => [a, f(a)] as const).sort((a, b) => order(a[1], b[1])).map((x) => x[0])
 )
 
 /**