Consider async operation in runSync as a defect, add span based stack (…

…#3717)
Effect-TS · Oct 2, 2024 · 83887ca · 83887ca
1 parent cdead5c
commit 83887ca
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/.changeset/proud-dolls-protect.md b/.changeset/proud-dolls-protect.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Consider async operation in runSync as a defect, add span based stack
diff --git a/packages/effect/src/internal/core.ts b/packages/effect/src/internal/core.ts
@@ -673,7 +673,7 @@ export const originalInstance = <E>(obj: E): E => {
 }
 
 /* @internal */
-const capture = <E>(obj: E & object, span: Option.Option<Tracer.Span>): E => {
+export const capture = <E>(obj: E & object, span: Option.Option<Tracer.Span>): E => {
   if (Option.isSome(span)) {
     return new Proxy(obj, {
       has(target, p) {

diff --git a/packages/effect/src/internal/runtime.ts b/packages/effect/src/internal/runtime.ts
@@ -250,7 +250,7 @@ export const unsafeRunSyncExit =
     if (result) {
       return result
     }
-    throw asyncFiberException(fiberRuntime)
+    return core.exitDie(core.capture(asyncFiberException(fiberRuntime), core.currentSpanFromFiber(fiberRuntime)))
   }
 
 /** @internal */

diff --git a/packages/effect/test/Effect/sync.test.ts b/packages/effect/test/Effect/sync.test.ts
@@ -14,6 +14,16 @@ const sum = (n: number): number => {
 }
 
 describe("Effect", () => {
+  it.it("runSyncExit with async is a defect with stack", () => {
+    const exit = Effect.runSyncExit(
+      Effect.promise(() => Promise.resolve(0)).pipe(Effect.withSpan("asyncSpan"))
+    )
+    if (Exit.isFailure(exit)) {
+      it.expect(Cause.pretty(exit.cause)).toContain("asyncSpan")
+    } else {
+      it.expect(exit._tag).toBe("Failure")
+    }
+  })
   it.effect("sync - effect", () =>
     Effect.gen(function*($) {
       const sumEffect = (n: number): Effect.Effect<number, unknown> => {