use Math.random for Hash.random (#3001)

Effect-TS · Jun 17, 2024 · a67b8fe · a67b8fe
1 parent 368d735
commit a67b8fe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.changeset/short-carrots-confess.md b/.changeset/short-carrots-confess.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+use Math.random for Hash.random
diff --git a/packages/effect/src/Hash.ts b/packages/effect/src/Hash.ts
@@ -4,18 +4,13 @@
 import { pipe } from "./Function.js"
 import { globalValue } from "./GlobalValue.js"
 import { hasProperty } from "./Predicate.js"
-import { PCGRandom, structuralRegionState } from "./Utils.js"
+import { structuralRegionState } from "./Utils.js"
 
 /** @internal */
 const randomHashCache = globalValue(
   Symbol.for("effect/Hash/randomHashCache"),
   () => new WeakMap<object, number>()
 )
-/** @internal */
-const pcgr = globalValue(
-  Symbol.for("effect/Hash/pcgr"),
-  () => new PCGRandom()
-)
 
 /**
  * @since 2.0.0
@@ -78,7 +73,7 @@ export const hash: <A>(self: A) => number = <A>(self: A) => {
  */
 export const random: <A extends object>(self: A) => number = (self) => {
   if (!randomHashCache.has(self)) {
-    randomHashCache.set(self, number(pcgr.integer(Number.MAX_SAFE_INTEGER)))
+    randomHashCache.set(self, number(Math.floor(Math.random() * Number.MAX_SAFE_INTEGER)))
   }
   return randomHashCache.get(self)!
 }