Skip to content

Commit

Permalink
allow Stream run fiber to close before trying to interrupt it (#3176)
Browse files Browse the repository at this point in the history
  • Loading branch information
tim-smart authored Jul 4, 2024
1 parent a9c4fb3 commit b5554db
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/few-pears-reply.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"effect": patch
---

allow Stream run fiber to close before trying to interrupt it
7 changes: 6 additions & 1 deletion packages/effect/src/internal/channel/channelExecutor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,12 @@ export const runScoped = <Env, InErr, InDone, OutErr, OutDone>(
Effect.forkScoped(restore(run(channelDeferred, scopeDeferred, child))),
Effect.flatMap((fiber) =>
pipe(
Effect.addFinalizer(() => Deferred.succeed(scopeDeferred, void 0)),
Scope.addFinalizer(
parent,
Deferred.succeed(scopeDeferred, void 0).pipe(
Effect.zipRight(Effect.yieldNow())
)
),
Effect.zipRight(restore(Deferred.await(channelDeferred))),
Effect.zipLeft(Fiber.inheritAll(fiber))
)
Expand Down

0 comments on commit b5554db

Please sign in to comment.