fix discard option in Effect.all (#2977)

Effect-TS · Jun 11, 2024 · df4bf4b · df4bf4b
1 parent f085f92
commit df4bf4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/nervous-houses-explain.md b/.changeset/nervous-houses-explain.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+fix discard option in Effect.all
diff --git a/packages/effect/src/internal/fiberRuntime.ts b/packages/effect/src/internal/fiberRuntime.ts
@@ -1826,7 +1826,7 @@ export const all = <
     return allEither(effects, reconcile, options) as any
   }
 
-  return reconcile._tag === "Some"
+  return options?.discard !== true && reconcile._tag === "Some"
     ? core.map(
       forEach(effects, identity, options as any),
       reconcile.value