ReadOnly Array flatMap stack overflow

[joepjoosten]

What version of Effect is running?

2.2.3

What steps can reproduce the bug?

import { pipe } from 'effect/Function';
import * as RA from 'effect/ReadonlyArray';

const arr: number[][] = [[]];
for (let i = 0; i < 135000; i++) {
  arr[0].push(i);
}

const flattened = pipe(
  arr,
  RA.flatMap((x) => x),
);

console.log(flattened.length);

What is the expected behavior?

135000

What do you see instead?

RangeError: Maximum call stack size exceeded
at ....../node_modules/.pnpm/effect@2.2.3/node_modules/effect/dist/cjs/ReadonlyArray.js:1046:9

Additional information

https://stackoverflow.com/questions/61740599/rangeerror-maximum-call-stack-size-exceeded-with-array-push

[joepjoosten]

Possibly also a problem in other places where spread operator is used...

[joepjoosten]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply#using_apply_and_built-in_functions

[joepjoosten]

I find 6 other places where this potentially also is a problem:
https://github.com/search?q=repo%3AEffect-TS%2Feffect%20push(...&type=code