Fix for possible stack overflow issues due to Array.push in combination with spread operator

[joepjoosten]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Related

• Closes ReadOnly Array flatMap stack overflow #2048

[changeset-bot]

🦋 Changeset detected

Latest commit: 41280d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
effect	Patch
@effect/platform	Patch
@effect/schema	Patch
@effect/cli	Patch
@effect/experimental	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-node	Patch
@effect/printer-ansi	Patch
@effect/printer	Patch
@effect/rpc-http-node	Patch
@effect/rpc-http	Patch
@effect/rpc-nextjs	Patch
@effect/rpc-workers	Patch
@effect/rpc	Patch
@effect/typeclass	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mikearnaldi]

Looks good, would you mind adding a changeset with patch level and a description of the change pls, you can generate one using pnpm changeset and following the wizard

[mikearnaldi]

The changeset is set at minor, should be set at patch

[mikearnaldi]

Seems like linter suggests two other places where spread is used

[tim-smart]

Does array.push.apply(array, otherArray) have the same issue?

[tim-smart]

Does array.push.apply(array, otherArray) have the same issue?

The answer is yes.

[joepjoosten]

Seems like linter suggests two other places where spread is used

When running lint locally, it doesn't complain, and i can't find the push it is complaining about...? Strange?

[mikearnaldi]

Very strange...