Fix for possible stack overflow issues due to Array.push in combination with spread operator

.changeset/tall-nails-retire.md

@@ -0,0 +1,7 @@
+---
+"effect": patch
+"@effect/platform": patch
+"@effect/schema": patch
+---
+
+Fix for possible stack overflow errors when using Array.push with spread operator arguments

.eslintrc.cjs

@@ -37,6 +37,10 @@ module.exports = {
     "object-shorthand": "error",
     "prefer-destructuring": "off",
     "sort-imports": "off",
+    "no-restricted-syntax": ["error", {
+        "selector": "CallExpression[callee.property.name='push'] > SpreadElement.arguments",
+        "message": "Do not use spread arguments in Array.push"
+    }],
     "no-unused-vars": "off",
     "prefer-rest-params": "off",
     "prefer-spread": "off",

packages/effect/src/ReadonlyArray.ts

@@ -1545,7 +1545,10 @@ export const flatMap: {
     }
     const out: Array<B> = []
     for (let i = 0; i < self.length; i++) {
-      out.push(...f(self[i], i))
+      const inner = f(self[i], i)
+      for (let j = 0; j < inner.length; j++) {
+        out.push(inner[j])
+      }
     }
     return out
   }

packages/effect/src/internal/differ/readonlyArrayPatch.ts

@@ -188,7 +188,9 @@ export const patch = Dual.dual<
         break
       }
       case "Append": {
-        readonlyArray.push(...head.values)
+        for (const value of head.values) {
+          readonlyArray.push(value)
+        }
         patches = tail
         break
       }

packages/effect/src/internal/stm/tMap.ts

@@ -661,7 +661,9 @@ const toReadonlyArray = <K, V>(self: TMap.TMap<K, V>): STM.STM<never, never, Rea
     let index = 0
     while (index < capacity) {
       const bucket = buckets.chunk[index]
-      builder.push(...tRef.unsafeGet(bucket, journal))
+      for (const entry of tRef.unsafeGet(bucket, journal)) {
+        builder.push(entry)
+      }
       index = index + 1
     }
     return builder

packages/effect/src/internal/stm/tPriorityQueue.ts

@@ -189,7 +189,9 @@ export const takeAll = <A>(self: TPriorityQueue.TPriorityQueue<A>): STM.STM<neve
   tRef.modify(self.ref, (map) => {
     const builder: Array<A> = []
     for (const entry of map) {
-      builder.push(...entry[1])
+      for (const value of entry[1]) {
+        builder.push(value)
+      }
     }
     return [builder, SortedMap.empty(SortedMap.getOrder(map))]
   })
@@ -228,7 +230,9 @@ export const takeUpTo = dual<
     while ((next = iterator.next()) && !next.done && index < n) {
       const [key, value] = next.value
       const [left, right] = pipe(value, ReadonlyArray.splitAt(n - index))
-      builder.push(...left)
+      for (const value of left) {
+        builder.push(value)
+      }
       if (right.length > 0) {
         updated = SortedMap.set(updated, key, right as [A, ...Array<A>])
       } else {
@@ -244,7 +248,9 @@ export const toChunk = <A>(self: TPriorityQueue.TPriorityQueue<A>): STM.STM<neve
   tRef.modify(self.ref, (map) => {
     const builder: Array<A> = []
     for (const entry of map) {
-      builder.push(...entry[1])
+      for (const value of entry[1]) {
+        builder.push(value)
+      }
     }
     return [Chunk.unsafeFromArray(builder), map]
   })
@@ -254,7 +260,9 @@ export const toArray = <A>(self: TPriorityQueue.TPriorityQueue<A>): STM.STM<neve
   tRef.modify(self.ref, (map) => {
     const builder: Array<A> = []
     for (const entry of map) {
-      builder.push(...entry[1])
+      for (const value of entry[1]) {
+        builder.push(value)
+      }
     }
     return [builder, map]
   })

packages/platform/src/internal/workerRunner.ts

@@ -106,7 +106,9 @@ export const make = <I, R, E, O>(
               return Effect.flatMap(
                 Effect.forEach(data, (data) => {
                   if (options?.transfers) {
-                    transfers.push(...options.transfers(data))
+                    for (const option of options.transfers(data)) {
+                      transfers.push(option)
+                    }
                   }
                   return Effect.orDie(options.encodeOutput!(req[2], data))
                 }),

packages/schema/src/AST.ts

@@ -1296,7 +1296,9 @@ export const getNumberIndexedAccess = (ast: AST): AST => {
         out.push(undefinedKeyword)
       }
       if (Option.isSome(ast.rest)) {
-        out.push(...ast.rest.value)
+        for (const e of ast.rest.value) {
+          out.push(e)
+        }
       }
       return createUnion(out)
     }