Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ReadonlyRecord key type #2009

Merged
merged 13 commits into from
Feb 14, 2024
Merged

add ReadonlyRecord key type #2009

merged 13 commits into from
Feb 14, 2024

Conversation

tim-smart
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9f0783b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Minor
@effect/platform Major
@effect/typeclass Major
@effect/cli Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart requested a review from gcanti January 30, 2024 00:52
@github-actions github-actions bot changed the base branch from main to next-minor January 30, 2024 00:53
gcanti
gcanti requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@gcanti gcanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the renaming 👍

packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
packages/effect/src/ReadonlyRecord.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot force-pushed the next-minor branch 6 times, most recently from 5d73da2 to 56b65a5 Compare January 30, 2024 23:32
@gcanti
Copy link
Contributor

gcanti commented Jan 31, 2024

Given the increasing number of changes, could we divide this PR into smaller, more manageable parts?

Like a PR containing:

  • add ReadonlyRecord.modify
  • rename ReadonlyRecord.upsert to .set
  • rename ReadonlyRecord.update to .replace

and a PR trying to add the K parameter (which instead is a tough nut to crack)

@tim-smart tim-smart changed the title refactor ReadonlyRecord apis add ReadonlyRecord key type Jan 31, 2024
@tim-smart tim-smart changed the base branch from next-minor to rr-renaming January 31, 2024 21:59
Base automatically changed from rr-renaming to next-minor February 1, 2024 19:59
@tim-smart tim-smart force-pushed the record-align branch 2 times, most recently from 14bf10c to 47fd163 Compare February 1, 2024 20:21
@tim-smart tim-smart requested a review from gcanti February 1, 2024 20:34
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
@IMax153
Copy link
Member

IMax153 commented Feb 3, 2024

@tim-smart - I think we have a bunch of conflicts.

@gcanti gcanti requested review from gcanti and removed request for mikearnaldi February 14, 2024 17:23
@github-actions github-actions bot force-pushed the next-minor branch 3 times, most recently from 01b50ad to 3640e0b Compare February 14, 2024 19:17
@tim-smart tim-smart merged commit 39144aa into next-minor Feb 14, 2024
12 checks passed
@tim-smart tim-smart deleted the record-align branch February 14, 2024 20:54
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Merged
tim-smart added a commit that referenced this pull request Feb 15, 2024
@tim-smart @gcanti
add ReadonlyRecord key type (#2009)
c25f425 
Co-authored-by: gcanti <giulio.canti@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@tim-smart @gcanti @mikearnaldi
add ReadonlyRecord key type (#2009)
c4d4841 
Co-authored-by: gcanti <giulio.canti@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@tim-smart @gcanti @mikearnaldi
add ReadonlyRecord key type (#2009)
00281db 
Co-authored-by: gcanti <giulio.canti@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@tim-smart @gcanti
add ReadonlyRecord key type (#2009)
5ed99fd 
Co-authored-by: gcanti <giulio.canti@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@tim-smart @gcanti @mikearnaldi
add ReadonlyRecord key type (#2009)
8133007 
Co-authored-by: gcanti <giulio.canti@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@tim-smart @gcanti
add ReadonlyRecord key type (#2009)
dba0ca2 
Co-authored-by: gcanti <giulio.canti@gmail.com>
mikearnaldi pushed a commit that referenced this pull request Feb 21, 2024
@tim-smart @gcanti @mikearnaldi
add ReadonlyRecord key type (#2009)
77c386b 
Co-authored-by: gcanti <giulio.canti@gmail.com>
mikearnaldi pushed a commit that referenced this pull request Feb 21, 2024
@tim-smart @gcanti @mikearnaldi
add ReadonlyRecord key type (#2009)
5de7be5 
Co-authored-by: gcanti <giulio.canti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikearnaldi mikearnaldi mikearnaldi left review comments

@gcanti gcanti Awaiting requested review from gcanti gcanti is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tim-smart @gcanti @IMax153 @mikearnaldi