add releaseAll api to Semaphore #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d0700a The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
force-pushed
the
semahore-release-all
branch
from
e2c5e8c
to
18613ca
Compare
tim-smart
commented
Feb 7, 2024
tim-smart
force-pushed
the
semahore-release-all
branch
from
18613ca
to
a054cb0
Compare
tim-smart
commented
Feb 7, 2024
| @@ -35,7 +35,7 @@ import * as supervisor from "../supervisor.js" | |||
|
|
|||
| /** @internal */ | |||
| class Semaphore { | |||
| public waiters = new Array<() => void>() | |||
| public waiters = new Array<() => boolean>() | |||
There was a problem hiding this comment.
Benchmarks show using a Set scales much better than an Array for this.
There was a problem hiding this comment.
Insertion order is preserved too, so it is safe to use.
tim-smart
force-pushed
the
semahore-release-all
branch
from
c9c53b3
to
edfebc6
Compare
tim-smart
force-pushed
the
semahore-release-all
branch
from
edfebc6
to
5d0700a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.