Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadonlyRecord: re-add symbol as valid key to some APIs #2164

Merged
merged 6 commits into from
Feb 16, 2024
Merged

ReadonlyRecord: re-add symbol as valid key to some APIs #2164

merged 6 commits into from
Feb 16, 2024

Conversation

gcanti
Copy link
Contributor

@gcanti gcanti commented Feb 16, 2024

  • empty
  • fromIterableWith
  • fromIterableBy
  • has
  • get
  • modify
  • modifyOption
  • replaceOption
  • remove
  • pop
  • set
  • replace
  • singleton

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cdfab0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gcanti
ReadonlyRecord: re-add symbol as valid key to some APIs
067c45b 
- empty
- fromIterableWith
- fromIterableBy
- has
- get
- modify
- modifyOption
- replaceOption
- remove
- pop
- set
- replace
- singleton
@gcanti
add support for ${number} to NonLiteralKey
522651d
@gcanti
remove useless cast
db0cf3b
@gcanti
clean up variable names
841478f
@gcanti
fix errors and optimize redact
faaef4d
@gcanti gcanti marked this pull request as ready for review February 16, 2024 15:26
@gcanti gcanti merged commit 71e4596 into next-minor Feb 16, 2024
12 checks passed
@gcanti gcanti deleted the chore/readonlyrecord-symbol branch February 16, 2024 15:27
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
mikearnaldi pushed a commit that referenced this pull request Feb 21, 2024
@gcanti @mikearnaldi
ReadonlyRecord: re-add symbol as valid key to some APIs (#2164)
521421a 
- empty
- fromIterableWith
- fromIterableBy
- has
- get
- modify
- modifyOption
- replaceOption
- remove
- pop
- set
- replace
- singleton
mikearnaldi pushed a commit that referenced this pull request Feb 21, 2024
@gcanti @mikearnaldi
ReadonlyRecord: re-add symbol as valid key to some APIs (#2164)
c05ab66 
- empty
- fromIterableWith
- fromIterableBy
- has
- get
- modify
- modifyOption
- replaceOption
- remove
- pop
- set
- replace
- singleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart Awaiting requested review from tim-smart tim-smart is a code owner

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gcanti