-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update typescript to 5.4 #2385
update typescript to 5.4 #2385
Conversation
🦋 Changeset detectedLatest commit: 0e1decd The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@gcanti Looks like there is an issue with Schema.tuple |
@tim-smart wow... it seems that there has been a significant change in the behavior of the built-in type from // ts 5.3
type A = readonly [string, ...number[], boolean]
type B = Required<A> // readonly [string, ...(number | boolean)[], number | boolean] to // ts 5.4
type A = readonly [string, ...number[], boolean]
type B = Required<A> // readonly [string, ...number[], boolean] |
The typescript 5.3 behaviour seems strange, unless I'm missing something. |
The 5.4 behaviour seems definitely more correct, probably a bugfix, all previous versions behaved differently, and I had to implement the "wrong" behaviour to keep runtime and type-level aligned. I think we should change the runtime to align with version 5.4 |
This will mean mis-alignment for previous typescript versions? I wonder if this should be in the next minor release. |
yes, but in any case, we have a mis-alignment, either with the previous versions or with version 5.4. However, the behaviour of version 5.4 is the "correct" one, so I would prioritize it and treat it as a bugfix |
No description provided.