Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support variadic arguments in Effect.log #2452

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

tim-smart
Copy link
Member

@tim-smart tim-smart commented Mar 31, 2024

No description provided.

Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: 66b31a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
effect Minor
@effect/cli Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor March 31, 2024 09:05
@tim-smart tim-smart changed the title log variadic support variadic arguments in Effect.log Mar 31, 2024
@mikearnaldi
Copy link
Member

mikearnaldi commented Apr 1, 2024

not sure about the interface of logger containing a cause imho, the idea would be to make the default loggers be:

/**
 * @since 2.0.0
 * @category constructors
 */
export const defaultLogger: Logger<unknown[], void> = fiberRuntime.defaultLogger

and be able to pass a variadic number of arguments of which some can be a Cause, I guess though this would be the less intrusive change

@mikearnaldi mikearnaldi merged commit f215eeb into next-minor Apr 2, 2024
12 checks passed
@mikearnaldi mikearnaldi deleted the log-variadic branch April 2, 2024 16:29
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants