Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider type of failure in Cause equality #2653

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

mikearnaldi
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 11887bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi mikearnaldi merged commit e79cb83 into main Apr 29, 2024
12 checks passed
@mikearnaldi mikearnaldi deleted the bugfix/cause-equality branch April 29, 2024 11:14
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
@sukovanej
Copy link
Contributor

this one will still fail

expect(
  Equal.equals(
    Cause.parallel(Cause.fail("fail1"), Cause.die("fail2")),
    Cause.parallel(Cause.fail("fail2"), Cause.die("fail1"))
  )
).toBe(false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants