-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capture stack trace for tracing spans #2673
Conversation
🦋 Changeset detectedLatest commit: 22bdee8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1b17dcc
to
5d6d9b7
Compare
we should probably have a way of disabling capture |
You can set |
This format while nice may break parsers, such as vitest, probably better to use:
|
true, I didn't see it in the functionWithSpan equivalent |
0028680
to
9c72a49
Compare
even more standard would be:
|
Not sure about |
Hmm ok, maybe we just capture 1 frame with YieldableError then? Then we will just have the line where the error was created. |
Why not using the custom trick? We could have commit call internally |
If we allowed breaking we could just rename commit, this is kind of an in between till 4.0 |
5dbe740
to
5f8f81a
Compare
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
No description provided.