Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional and optionalWithOptions API interfaces #2794

Merged
merged 1 commit into from
May 21, 2024

Conversation

gcanti
Copy link
Contributor

@gcanti gcanti commented May 21, 2024

@gcanti gcanti added the schema label May 21, 2024
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 3140d59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@effect/schema Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gcanti
Copy link
Contributor Author

gcanti commented May 21, 2024

@vinassefranche this also resolves the issue with the old as consts, not just the new ones 🙌

Copy link
Contributor

@vinassefranche vinassefranche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Is it mostly the use of LazyArg that fixes the issue or separating into optional and optionalWithOptions ?(or both were needed?)

@gcanti
Copy link
Contributor Author

gcanti commented May 21, 2024

No the use of LazyArg is merely cosmetic. Adding these API interfaces was something I had wanted to do for a while, and in doing so, I realized that the issue disappeared. TypeScript is weird.

@gcanti gcanti merged commit 78ffc27 into main May 21, 2024
12 checks passed
@gcanti gcanti deleted the schema/optional-api-interfaces branch May 21, 2024 09:22
@github-actions github-actions bot mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants