Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Config module, closes #2346 #2816

Merged
merged 2 commits into from
May 22, 2024
Merged

Add support for Config module, closes #2346 #2816

merged 2 commits into from
May 22, 2024

Conversation

gcanti
Copy link
Contributor

@gcanti gcanti commented May 22, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Related

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: cf59ec2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@effect/schema Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@vecerek vecerek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very similar to my suggestion in #2763 (comment)

Instant approve 😀👍

@jessekelly881
Copy link
Contributor

Looks great!

@gcanti
Copy link
Contributor Author

gcanti commented May 22, 2024

Looks very similar to my suggestion in #2763 (comment)

Yes 👍 , this issue lacked a proposal and your implementation is nice and works, except for an extra name in

-InvalidData([name], TreeFormatter.formatErrorSync(error))
+InvalidData([], TreeFormatter.formatErrorSync(error))

@gcanti gcanti marked this pull request as ready for review May 22, 2024 17:48
@gcanti gcanti merged commit e376641 into main May 22, 2024
12 checks passed
@gcanti gcanti deleted the fix/2346 branch May 22, 2024 19:06
@github-actions github-actions bot mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a Schema.config for decoding Configs using a Schema.
3 participants