Add Either.liftPredicate

[LaureRC]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Add Either.liftPredicate. In my current project we were missing it so we created a custom helper for it, but I found out in the Discord that other people would like it to be implemented (see thread here). So I figured it could be an opportunity to contribute here!

I took inspiration from Option.fromPredicate but I went a bit further and made Either.liftPredicate dual

Related

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: f866029

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
effect	Minor
@effect/cli	Major
@effect/experimental	Major
@effect/opentelemetry	Major
@effect/platform-browser	Major
@effect/platform-bun	Major
@effect/platform-node-shared	Major
@effect/platform-node	Major
@effect/platform	Major
@effect/printer-ansi	Major
@effect/printer	Major
@effect/rpc-http	Major
@effect/rpc	Major
@effect/schema	Major
@effect/sql-mssql	Major
@effect/sql-mysql2	Major
@effect/sql-pg	Major
@effect/sql-sqlite-bun	Major
@effect/sql-sqlite-node	Major
@effect/sql-sqlite-react-native	Major
@effect/sql-sqlite-wasm	Major
@effect/sql	Major
@effect/typeclass	Major
@effect/vitest	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gcanti]

the B type parameter seems redundant, I would remove it:

export const liftPredicate: {
  <A, B extends A, E>(refinement: Refinement<NoInfer<A>, B>, orLeftWith: (a: NoInfer<A>) => E): (a: A) => Either<B, E>
  <A, E>(
    predicate: Predicate<NoInfer<A>>,
    orLeftWith: (a: NoInfer<A>) => E
  ): (a: A) => Either<A, E>
  <A, E, B extends A>(
    self: A,
    refinement: Refinement<A, B>,
    orLeftWith: (a: A) => E
  ): Either<B, E>
  <A, E>(
    self: A,
    predicate: Predicate<A>,
    orLeftWith: (a: A) => E
  ): Either<A, E>
} = dual(
  3,
  <A, E>(a: A, predicate: Predicate<A>, orLeftWith: (a: A) => E): Either<A, E> =>
    predicate(a) ? right(a) : left(orLeftWith(a))
)

[LaureRC]

Thanks for the review @gcanti! I've pushed some more commits to update what you suggested. I just had a typing issue in my tests (on this line), but fixed it by adding a NoInfer where it was needed!