ensure "cause" is rendered in Data.Error output #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e9edd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/snapshot |
|
Good news @tim-smart, your snapshot has been published! pnpm add @effect/cli@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/cluster@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/cluster-browser@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/cluster-node@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/cluster-workflow@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add effect@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/experimental@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/opentelemetry@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/platform@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/platform-browser@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/platform-bun@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/platform-node@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/platform-node-shared@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/printer@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/printer-ansi@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/rpc@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/rpc-http@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/schema@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-drizzle@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-mssql@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-mysql2@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-pg@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-sqlite-bun@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-sqlite-node@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-sqlite-react-native@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/sql-sqlite-wasm@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/typeclass@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7pnpm add @effect/vitest@0.0.0-snapshot-6e9edd448c6d82afd40e9d971340ed91efdcfce7You can review the build log here. |
johtso
reviewed
Jul 6, 2024
| @@ -2174,23 +2174,19 @@ export const causeSquashWith = dual< | |||
| // ----------------------------------------------------------------------------- | |||
|
|
|||
| /** @internal */ | |||
| export const YieldableError: new(message?: string) => Cause.YieldableError = (function() { | |||
| export const YieldableError: new(message?: string, options?: ErrorOptions) => Cause.YieldableError = (function() { | |||
There was a problem hiding this comment.
What effect is this change supposed to have? Is it supposed to change the default arguments to a Data.TaggedError for example?
Merged
tim-smart
added a commit
that referenced
this pull request
Jul 8, 2024
tim-smart
added a commit
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.