Introduce bindAll

[KhraksMamtsov]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Related

• Related Issue #
• Closes From Discord: Proposed Do Notation Syntax: bindAll with Unbounded Concurrency #3484

[changeset-bot]

🦋 Changeset detected

Latest commit: 817f169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
effect	Minor
@effect/cli	Major
@effect/cluster-browser	Major
@effect/cluster-node	Major
@effect/cluster-workflow	Major
@effect/cluster	Major
@effect/experimental	Major
@effect/opentelemetry	Major
@effect/platform-browser	Major
@effect/platform-bun	Major
@effect/platform-node-shared	Major
@effect/platform-node	Major
@effect/platform	Major
@effect/printer-ansi	Major
@effect/printer	Major
@effect/rpc-http	Major
@effect/rpc	Major
@effect/schema	Major
@effect/sql-d1	Major
@effect/sql-drizzle	Major
@effect/sql-kysely	Major
@effect/sql-mssql	Major
@effect/sql-mysql2	Major
@effect/sql-pg	Major
@effect/sql-sqlite-bun	Major
@effect/sql-sqlite-node	Major
@effect/sql-sqlite-react-native	Major
@effect/sql-sqlite-wasm	Major
@effect/sql	Major
@effect/typeclass	Major
@effect/vitest	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gcanti]

is bindAll truly necessary when nesting can achieve pretty much the same result without introducing new APIs?

Effect.Do.pipe(
  Effect.bind("x", () => Effect.succeed(2)),
  Effect.bind("y", ({ x }) =>
    Effect.all({
      a: Effect.succeed(x),
      b: Effect.succeed("ops")
    }, { mode: "either" }))
)

vs

Effect.Do.pipe(
  Effect.bind("x", () => Effect.succeed(2)),
  Effect.bindAll(({ x }) => ({
    a: Effect.succeed(x),
    b: Effect.succeed("ops")
  }), { mode: "either" })
)

[tim-smart]

is bindAll truly necessary when nesting can achieve pretty much the same result without introducing new APIs?

With Effect.all you will need to follow that up with merging y into the result. So the equivalent would be:

Effect.Do.pipe(
  Effect.bind("x", () => Effect.succeed(2)),
  Effect.flatMap((value) =>
    Effect.all(
      {
        a: Effect.succeed(value.x),
        b: Effect.succeed("ops"),
      },
      { concurrency: "unbounded" },
    ).pipe(Effect.map((result) => ({ ...value, ...result }))),
  ),
)

[KhraksMamtsov]

On the one hand, I agree with Guilio. On the other hand, I saw that Michael approved of the idea. I had time to contribute to the effect and practice with the types)

[KhraksMamtsov]

@tim-smart, please confirm that everything is fine

[tim-smart]

/rebase

[tim-smart]

/rebase