Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve Array.modify and Array.modifyOption non emptiness #3496

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Preserve Array.modify and Array.modifyOption non emptiness #3496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d271ba
Preserve non emptiness for Array.modify and Array.modifyOption
vinassefranche Aug 22, 2024
2151140
Add changeset
vinassefranche Aug 22, 2024
b58cdd4
Fix bad inference of function parameter
vinassefranche Aug 22, 2024
51c716a
Merge branch 'next-minor' into preserve-array-replace-non-emptiness
vinassefranche Aug 22, 2024
a47f382
Separate modify and modifyOption in dtslint
vinassefranche Aug 22, 2024
dc32dce
Use existing type helper
vinassefranche Aug 22, 2024
ec4acb7
Improve dtslint tests
vinassefranche Aug 22, 2024
da5813e
Fix inference of n parameter for data last variant
vinassefranche Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/effect/dtslint/Array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,10 +1371,10 @@ Array.modify(new Set([1, 2] as const), 0, () => "a" as const)
// $ExpectType Option<("a" | 1 | 2)[]>
Array.modifyOption(new Set([1, 2] as const), 0, () => "a" as const)

// $ExpectType [number | "a", ...(number | "a")[]]
Array.modify(Array.of(1), 0, () => "a" as const)
// $ExpectType Option<[number | "a", ...(number | "a")[]]>
Array.modifyOption(Array.of(1), 0, () => "a" as const)
// $ExpectType [number | string, ...(number | string)[]]
Array.modify(Array.of(1), 0, (n) => n.toString())
// $ExpectType Option<[number | string, ...(number | string)[]]>
Array.modifyOption(Array.of(1), 0, (n) => n.toString())

// $ExpectType string[]
pipe([], Array.modify(0, () => "a"))
Expand Down
6 changes: 4 additions & 2 deletions packages/effect/src/Array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,8 @@ export const replaceOption: {
<A, B>(self: Iterable<A>, i: number, b: B): Option<Array<A | B>> => modifyOption(self, i, () => b)
)

type TypeOfIterable<T extends Iterable<any>> = T extends Iterable<infer A> ? A : never
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I fixed the inference of a. Tell me if:

  • it's a valid way to fix the issue
  • it's the correct place to put this kind of the type helpers (or if it already exists somewhere. I did not find anything on my own)


/**
* Apply a function to the element at the specified index, creating a new `Array`,
* or return a copy of the input if the index is out of bounds.
Expand All @@ -1118,7 +1120,7 @@ export const modify: {
<A, B, S extends Iterable<A> = Iterable<A>>(
self: S,
i: number,
f: (a: A) => B
f: (a: TypeOfIterable<S>) => B
): ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>
} = dual(
3,
Expand Down Expand Up @@ -1150,7 +1152,7 @@ export const modifyOption: {
<A, B, S extends Iterable<A> = Iterable<A>>(
self: S,
i: number,
f: (a: A) => B
f: (a: TypeOfIterable<S>) => B
): Option<ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>>
} = dual(3, <A, B>(self: Iterable<A>, i: number, f: (a: A) => B): Option<Array<A | B>> => {
const out = Array.from(self)
Expand Down