Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renders the default for all Prompt types that accepts TextOptions. #3508

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

cdierkens
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR renders all Prompt types that accepts TextOptions.

  1. Intially, the text is rendered in a muted fashion.
  2. When the user hits the tab key the value is accepted and rendered in cyan.
  3. Finally, the user can edit the entered text or hit enter to submit the text.
Screen.Recording.2024-08-27.at.10.55.23.PM.mov

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 61c3ae8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/cli/src/internal/prompt/text.ts Outdated Show resolved Hide resolved
packages/cli/src/internal/prompt/text.ts Outdated Show resolved Hide resolved
packages/cli/test/Prompt.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@IMax153 IMax153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed this on the first pass. After this small change this PR looks good to go. I'll trigger CI to make sure now.

packages/cli/test/Prompt.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Maxwell Brown <maxwellbrown1990@gmail.com>
@cdierkens
Copy link
Contributor Author

Sorry - I missed this on the first pass. After this small change this PR looks good to go. I'll trigger CI to make sure now.

No worries.

@cdierkens cdierkens requested a review from IMax153 August 29, 2024 00:15
@IMax153 IMax153 merged commit 8e64b1a into Effect-TS:main Aug 29, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants