Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HashMap.HashMap.Entry utility type #3618

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

vinassefranche
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adds HashMap.HashMap.Entry utility type which is just [HashMap.HashMap.Key<>, HashMap.HashMap.Value<>]

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 702f010

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor September 16, 2024 08:32
@vinassefranche
Copy link
Contributor Author

I tried to add some types tests with:

// $ExpectType ["k", "v"]
export type E = HashMap.HashMap.Entry<typeof hmLiterals>

but I had this error and did not know what to do about it:

ERROR: 31:1  expect  TypeScript@5.5 expected type to be:
  ["k", "v"]
got:
  E

Tell me if you have an idea on how to fix it

@gcanti
Copy link
Contributor

gcanti commented Sep 16, 2024

you can use

import { hole, pipe } from "effect/Function"
import type * as Types from "effect/Types"

// $ExpectType ["k", "v"]
hole<Types.Simplify<HashMap.HashMap.Entry<typeof hmLiterals>>>()

@vinassefranche
Copy link
Contributor Author

you can use

import { hole, pipe } from "effect/Function"
import type * as Types from "effect/Types"

// $ExpectType ["k", "v"]
hole<Types.Simplify<HashMap.HashMap.Entry<typeof hmLiterals>>>()

Great! Added to the P.R.!

@gcanti gcanti merged commit 0e7fe8b into Effect-TS:next-minor Sep 16, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
@vinassefranche vinassefranche deleted the add-Entry-type-on-hashmap branch September 16, 2024 18:05
@tim-smart tim-smart mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants