Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect.provide(managedRuntime) and ManagedRuntime<R, E> is subtype of Effect<Runtime<R>, E, never> #3677

Merged

Conversation

leonitousconforti
Copy link
Contributor

@leonitousconforti leonitousconforti commented Sep 24, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Just trying to see if this is how it would be done, really uncertain though.

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: a1b3b60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leonitousconforti leonitousconforti changed the title Effect.provide(managedRuntime) Effect.provide(managedRuntime) and ManagedRuntime<R, E> is subtype of Effect<Runtime<R>, E, never> Sep 24, 2024
@leonitousconforti leonitousconforti marked this pull request as ready for review September 24, 2024 19:51
@github-actions github-actions bot changed the base branch from main to next-minor September 24, 2024 19:55
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/internal/layer.ts Outdated Show resolved Hide resolved
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/ManagedRuntime.ts Outdated Show resolved Hide resolved
packages/effect/src/internal/managedRuntime.ts Outdated Show resolved Hide resolved
@leonitousconforti
Copy link
Contributor Author

Ahhhhhh I did not run the circular command because I didn't think I needed to 😭

@tim-smart
Copy link
Member

Ahhhhhh I did not run the circular command because I didn't think I needed to 😭

No worries, I'll quickly fix that now.

@leonitousconforti
Copy link
Contributor Author

Ahhhhhh I did not run the circular command because I didn't think I needed to 😭

No worries, I'll quickly fix that now.

Thanks @tim-smart! Looks like I also messed up the dtslint during one of the merges

@tim-smart tim-smart merged commit 379ba4c into Effect-TS:next-minor Sep 24, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@leonitousconforti leonitousconforti deleted the Effect.provide(managedRuntime) branch September 25, 2024 04:45
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@tim-smart tim-smart mentioned this pull request Sep 26, 2024
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
github-actions bot pushed a commit that referenced this pull request Sep 28, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
github-actions bot pushed a commit that referenced this pull request Oct 5, 2024
github-actions bot pushed a commit that referenced this pull request Oct 6, 2024
github-actions bot pushed a commit that referenced this pull request Oct 6, 2024
github-actions bot pushed a commit that referenced this pull request Oct 6, 2024
github-actions bot pushed a commit that referenced this pull request Oct 6, 2024
github-actions bot pushed a commit that referenced this pull request Oct 6, 2024
tim-smart pushed a commit that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants