Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to help migrate to TCA 1.0, but there are many issues should be fix first.
In this pr, I fix most of the easy to fix issues. Viewing by commit should be clearer to review
In each commit:
Find and replace text
Replace
Effect.init(value:)
withEffect.send()
Replace
Effect.fireAndForget
withEffect.run()
Fix Store init with Reducer in trailing block
Add observe block in ViewStore init. Use
{ $0 }
because that it is equivalentRemove using unnecessary .binding function
Remove final call to
eraseToEffect
and wrap insideEffect.publisher
. However this still won't be compatible with TCA 1.0 but we can fix it later. Because in TCA 1.0 Effect conforms toPublisher
is deprecated.Explicitly specify all cases of
CancelID