Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCA Warnings #368

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Conversation

Jimmy-Prime
Copy link
Contributor

@Jimmy-Prime Jimmy-Prime commented Mar 17, 2024

Hi, I want to help migrate to TCA 1.0, but there are many issues should be fix first.
In this pr, I fix most of the easy to fix issues. Viewing by commit should be clearer to review


In each commit:

Find and replace text

Replace Effect.init(value:) with Effect.send()

Replace Effect.fireAndForget with Effect.run()

Fix Store init with Reducer in trailing block

Add observe block in ViewStore init. Use { $0 } because that it is equivalent

Remove using unnecessary .binding function

Remove final call to eraseToEffect and wrap inside Effect.publisher. However this still won't be compatible with TCA 1.0 but we can fix it later. Because in TCA 1.0 Effect conforms to Publisher is deprecated.

Explicitly specify all cases of CancelID

@tatsuz0u
Copy link
Contributor

Thank you for your contribution!
We will be reviewing it shortly. 😋

@chihchy chihchy changed the base branch from main to develop April 4, 2024 06:19
Copy link
Member

@chihchy chihchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chihchy chihchy merged commit 6f04b56 into EhPanda-Team:develop Apr 4, 2024
@Jimmy-Prime Jimmy-Prime deleted the jimmy/fix-tca-warnings branch April 5, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants