fix: extend RadioButtonProps and CheckBoxProps to OcBaseProps (#143)

* fix: extend RadioButtonProps and CheckBoxProps to OcBaseProps * fix: add null check to onRadioButtonClick call Co-authored-by: yash <yash@MacBook-Pro-Yash-Kelkar-RQMM9RC70H.local>
EightfoldAI · May 25, 2022 · e8a0280 · e8a0280
1 parent 1b74497
commit e8a0280
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/components/Selectors/RadioButton/RadioButton.tsx b/src/components/Selectors/RadioButton/RadioButton.tsx
@@ -44,7 +44,7 @@ export const RadioButton: FC<RadioButtonProps> = ({
                 value={value}
                 onClick={(e) => {
                     updateActiveRadioButton(value);
-                    onRadioButtonClick(value, e);
+                    onRadioButtonClick?.(value, e);
                 }}
                 readOnly
             />

diff --git a/src/components/Selectors/Selectors.types.ts b/src/components/Selectors/Selectors.types.ts
@@ -1,4 +1,5 @@
 import React from 'react';
+import { OcBaseProps } from '../OcBase';
 
 export type SelectRadioButtonEvent<E = HTMLElement> =
     | React.MouseEvent<E>
@@ -22,7 +23,7 @@ export interface IRadioButtonsContext {
     onRadioButtonClick: OnChangeHandler;
 }
 
-export interface CheckBoxProps {
+export interface CheckBoxProps extends OcBaseProps<HTMLInputElement> {
     /**
      * Allows focus on the checkbox when it's disabled.
      */
@@ -70,7 +71,8 @@ export interface CheckBoxProps {
     onChange?: React.ChangeEventHandler<HTMLInputElement>;
 }
 
-export interface RadioButtonProps {
+export interface RadioButtonProps
+    extends Omit<OcBaseProps<HTMLElement>, 'onChange'> {
     /**
      * The default radio button to select
      */