fix: make stepper region focusable if scrollable #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
jhoward-eightfold
approved these changes
Aug 22, 2024
jhoward-eightfold
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
+ Coverage 84.53% 84.63% +0.09%
==========================================
Files 1099 1099
Lines 20405 20406 +1
Branches 7711 7712 +1
==========================================
+ Hits 17249 17270 +21
+ Misses 3071 3049 -22
- Partials 85 87 +2 ☔ View full report in Codecov by Sentry. |
jhoward-eightfold
added a commit
that referenced
this pull request
Aug 27, 2024
* fix: stepper region: fixed issue by making stepper region focusable * fix: stepper region: updated test snapshot for stepper * fix: stepper region: updated tabindex attribute condition * fix: stepper region: added test case for scrollable stepper --------- Co-authored-by: Jeff Howard <106610186+jhoward-eightfold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
In the case of onboarding flow, was getting axe devtools issue saying "Scrollable region must have keyboard access". So added a tabindex attribute to make the stepper region focusable to fix the issue.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-85455
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: