Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make stepper region focusable if scrollable #876

Merged
merged 6 commits into from
Aug 23, 2024
Merged

fix: make stepper region focusable if scrollable #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b19dd3
fix: stepper region: fixed issue by making stepper region focusable
cpatil-c-eightfold Aug 21, 2024
b03e661
fix: stepper region: updated test snapshot for stepper
cpatil-c-eightfold Aug 21, 2024
23aab47
fix: stepper region: updated tabindex attribute condition
cpatil-c-eightfold Aug 22, 2024
526231c
fix: stepper region: added test case for scrollable stepper
cpatil-c-eightfold Aug 22, 2024
631718d
Merge branch 'main' into cpatil-fix-for-making-stepper-region-focusable
cpatil-c-eightfold Aug 23, 2024
eb47b77
Merge branch 'main' into cpatil-fix-for-making-stepper-region-focusable
jhoward-eightfold Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Stepper/Stepper.tsx
View file
Open in desktop
cpatil-c-eightfold marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ export const Stepper: FC<StepperProps> = React.forwardRef(
className={styles.stepsContainer}
onScroll={handleScroll}
ref={stepsContainerRef}
tabIndex={mergedScrollable ? 0 : null}
>
<ul className={styles.steps} ref={stepsRef}>
{steps.map((step: Step, index: number) => {
Expand Down
12 changes: 12 additions & 0 deletions src/components/Stepper/Tests/Stepper.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,16 @@ describe('Stepper', () => {
);
expect(wrapper.render()).toMatchSnapshot();
});

test('Stepper is scrollable', () => {
const wrapper = mount(
<Stepper
{...stepperArgs}
size={StepperSize.Small}
steps={defaultWorkflow}
scrollable
/>
);
expect(wrapper.render()).toMatchSnapshot();
});
});
Loading
Loading