Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip: fixes tooltip visibility upon on mouse leave #273

Merged

Conversation

mfazil-eightfold
Copy link
Contributor

SUMMARY:

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-24280

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a03d14f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage        ?   88.38%           
=======================================
  Files           ?      384           
  Lines           ?    10349           
  Branches        ?     3477           
=======================================
  Hits            ?     9147           
  Misses          ?     1182           
  Partials        ?       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03d14f...d379894. Read the comment docs.

@ychhabra-eightfold ychhabra-eightfold merged commit 0314b8c into EightfoldAI:main Jul 28, 2022
dkilgore-eightfold pushed a commit to dkilgore-eightfold/octupledownstream that referenced this pull request Aug 2, 2022
dkilgore-eightfold added a commit that referenced this pull request Aug 3, 2022
* feat: tooltip: allow passing custom class and style to tooltip wrapper (#264)

(cherry picked from commit 4eeb0e4)

* fix: slider: fixes slider onresize event hang in react 16

(cherry picked from commit ac14f79)

* fix: tooltip: fixes tooltip visibility upon on mouse leave (#273)

(cherry picked from commit 0314b8c)

* fix: slider: fixes slider onchange event hang in react 16

adds some typings

(cherry picked from commit 4476c86)

* fix: snackbar: increase snackbar z-index to be more than surface elements (#277)

(cherry picked from commit 40d8840)

* feat: codesandbox: adds basic codesandbox ci pr build config

(cherry picked from commit e4eb710)

* chore: codesandbox: add node config

(cherry picked from commit 2b1f3ee)

* chore: codesandbox: bump node engine down to >= 16.13.0 to enable ci build

(cherry picked from commit 5a3f1da)

* fix: match score: update logic for filled and half filled scores

* fix: radio group: updates story implementation to scope selection states

* fix: radiobutton: fixes width of radio element in flex when layout is constrained

* fix: button: fixes secondary button border in safari, cleans up focus visible styles

ports only what is needed for theme 1

Co-authored-by: Yash raj chhabra <95337653+ychhabra-eightfold@users.noreply.github.com>
Co-authored-by: mfazil-eightfold <109717425+mfazil-eightfold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants