Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table: add page sizes prop to table pagination #393

Merged
merged 10 commits into from
Sep 27, 2022
Merged

fix: table: add page sizes prop to table pagination #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4cd0de6
chore: table: initial commit of render fixup
dkilgore-eightfold Sep 27, 2022
184b0b5
chore: update console logs
dkilgore-eightfold Sep 27, 2022
c74edb6
chore: table: fixes pagination sizes update to render proper num of rows
dkilgore-eightfold Sep 27, 2022
b69a73d
chore: table: optimise size change in hook
dkilgore-eightfold Sep 27, 2022
be748a9
chore: table: update debug log comments
dkilgore-eightfold Sep 27, 2022
bd4cfac
chore: table: default page size
dkilgore-eightfold Sep 27, 2022
ca2ed59
fix: table: add page sizes prop to table pagination
dkilgore-eightfold Sep 27, 2022
b5c471e
chore: select: fix flaky unit tests
dkilgore-eightfold Sep 27, 2022
9fb1888
chore: merge latest main
dkilgore-eightfold Sep 27, 2022
2342025
chore: update select snap
dkilgore-eightfold Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/components/Select/Select.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,32 +122,32 @@ describe('Select', () => {
});

test('Select is large', () => {
const wrapper = mount(<Select size={SelectSize.Large} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select size={SelectSize.Large} />);
expect(container.firstChild).toMatchSnapshot();
});

test('Select is medium', () => {
const wrapper = mount(<Select size={SelectSize.Medium} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select size={SelectSize.Medium} />);
expect(container.firstChild).toMatchSnapshot();
});

test('Select is small', () => {
const wrapper = mount(<Select size={SelectSize.Small} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select size={SelectSize.Small} />);
expect(container.firstChild).toMatchSnapshot();
});

test('Select is rectangle shaped', () => {
const wrapper = mount(<Select shape={SelectShape.Rectangle} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select shape={SelectShape.Rectangle} />);
expect(container.firstChild).toMatchSnapshot();
});

test('Select is pill shaped', () => {
const wrapper = mount(<Select shape={SelectShape.Pill} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select shape={SelectShape.Pill} />);
expect(container.firstChild).toMatchSnapshot();
});

test('Select is underline shaped', () => {
const wrapper = mount(<Select shape={SelectShape.Underline} />);
expect(wrapper.render()).toMatchSnapshot();
const { container } = render(<Select shape={SelectShape.Underline} />);
expect(container.firstChild).toMatchSnapshot();
});
});
Loading