Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip: fixes tooltip toggle on mobile devices #668

Merged
merged 14 commits into from
Aug 17, 2023
Merged

fix: tooltip: fixes tooltip toggle on mobile devices #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d1bc674
fix: tooltip: fixes tooltip toggle on mobile devices
dkilgore-eightfold Jul 17, 2023
9074f1c
chore: tooltip: adds click toggle unit test
dkilgore-eightfold Jul 17, 2023
78347c3
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 19, 2023
4ab60ab
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 20, 2023
e25eedc
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 21, 2023
635eab4
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 21, 2023
9d6f6fc
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 24, 2023
78ab7c6
chore: coverage: adds tooltip and mobile detector tests
dkilgore-eightfold Jul 24, 2023
33b2c22
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Jul 24, 2023
14cc961
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Aug 9, 2023
763ed12
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Aug 15, 2023
6ae75db
chore: popup: adds istouching method to test for hybrid devices
dkilgore-eightfold Aug 15, 2023
dca3d65
chore: popup: update function name and ensure cloned element props ar…
dkilgore-eightfold Aug 16, 2023
d17e2ee
Merge branch 'main' into dkilgore-eightfold/popup-reference-touch-tog…
dkilgore-eightfold Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ exports[`Breadcrumb Crumb should support string \`0\` and number \`0\` 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="0"
Expand Down Expand Up @@ -58,6 +60,8 @@ exports[`Breadcrumb Crumb should support string \`0\` and number \`0\` 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="0"
Expand Down Expand Up @@ -94,7 +98,9 @@ exports[`Breadcrumb Crumb should use custom links 1`] = `
<a
aria-disabled="false"
class="link-style full-width secondary"
data-reference-id="tooltip--reference"
href="#"
id="tooltip--reference"
role="link"
target="_self"
title="undefined"
Expand Down Expand Up @@ -131,7 +137,9 @@ exports[`Breadcrumb Crumb should use custom links 1`] = `
<a
aria-disabled="false"
class="link-style full-width disruptive"
data-reference-id="tooltip--reference"
href="#"
id="tooltip--reference"
role="link"
target="_self"
title="undefined"
Expand Down Expand Up @@ -167,7 +175,9 @@ exports[`Breadcrumb Crumb should use custom links 1`] = `
>
<span
aria-current="location"
class="breadcrumb-link my-breadcrumb-links-class breadcrumb-link-read-only"
class="tooltip-reference breadcrumb-link my-breadcrumb-links-class breadcrumb-link-read-only"
data-reference-id="tooltip--reference"
id="tooltip--reference"
>
Page 2
</span>
Expand Down Expand Up @@ -202,6 +212,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Home"
Expand Down Expand Up @@ -239,6 +251,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 1"
Expand Down Expand Up @@ -276,6 +290,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 2"
Expand Down Expand Up @@ -313,6 +329,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 3"
Expand Down Expand Up @@ -350,6 +368,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 4"
Expand Down Expand Up @@ -387,6 +407,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 5"
Expand Down Expand Up @@ -424,6 +446,8 @@ exports[`Breadcrumb Renders without crashing 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="Page 6"
Expand Down Expand Up @@ -477,6 +501,8 @@ exports[`Breadcrumb should support custom attribute 1`] = `
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-custom="custom-item"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="xxx"
Expand Down Expand Up @@ -513,6 +539,8 @@ exports[`Breadcrumb should support custom attribute 1`] = `
<a
aria-disabled="false"
class="link-style full-width primary breadcrumb-link my-breadcrumb-links-class"
data-reference-id="tooltip--reference"
id="tooltip--reference"
role="link"
target="_self"
title="yyy"
Expand Down
3 changes: 3 additions & 0 deletions src/components/Popup/Popup.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ const Popup_Story: ComponentStory<typeof Popup> = (args) => {
return (
<Popup {...args} onVisibleChange={(isVisible) => setVisibility(isVisible)}>
<PrimaryButton
onClick={() => {
console.log('clicked');
}}
size={ButtonSize.Medium}
text={visible ? 'Hide Popup' : 'Show Popup'}
/>
Expand Down
Loading