Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new icon mdiMicrosoftTeams #794

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

sbandapalli-eightfold
Copy link
Contributor

@sbandapalli-eightfold sbandapalli-eightfold commented Mar 13, 2024

SUMMARY:

Adding new mdi icon mdiMicrosoftTeams

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-82321

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Tested on storybook.
Screenshot 2024-03-13 at 4 12 33 PM

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (cef81b5) to head (d9b6950).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files        1009     1009           
  Lines       19896    19896           
  Branches     7540     7540           
=======================================
+ Hits        16789    16790    +1     
+ Misses       3024     3023    -1     
  Partials       83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold
Copy link
Contributor

FYI: Adding an icon is a chore, not a feat.

@dkilgore-eightfold dkilgore-eightfold merged commit 4b121f4 into main Mar 13, 2024
7 of 10 checks passed
@dkilgore-eightfold dkilgore-eightfold deleted the sbandapalli-add-ms-teams-icon branch March 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants