fix: select: populate selected options text on component render #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 84.66% 84.66% -0.01%
==========================================
Files 1099 1099
Lines 20422 20423 +1
Branches 7720 7720
==========================================
Hits 17291 17291
- Misses 3044 3045 +1
Partials 87 87 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
The
selectedOptionTextinside the Select component was not setting when we are opening a HookForm in edit mode with pre-filled values.Reason: Currently, the
selectedOptionTextis only calculated at render + when selected options changes. But in case of HookForm with initialValues, we use the hook_form's setValue method to pass on the initial value to SelectField which updates theoptionsprop inside octuple'sSelectcomponent.GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-116130
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
/candidate/login?domain=eightfolddemo-pcsx-demo.com(sprajapati+demo4@eightfold.ai / Welcome@1)/careers/forms/center?domain=eightfolddemo-pcsx-demo.com&customredirect=1&tab=expenseEditon any existing form request. Verify that the Category and Currency fields are pre-filled. Reload the page and verify again.