Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Added focus border on Tabs. #916

Conversation

rmotwani-c-eightfold
Copy link
Contributor

@rmotwani-c-eightfold rmotwani-c-eightfold commented Dec 2, 2024

SUMMARY:

  • Added focus border on Tabs.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

Jira task - https://eightfoldai.atlassian.net/browse/ENG-117818

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • pull branch down locally and start storybook (yarn storybook)
  • Navigate to the tabs component, and using tab focus on any of the tabs and observe that a focus border is visible.

UI Impact:

  • Go to - /position/pipeline_v2?pid=481052551587&review_mode=pipeline_v2_leads
  • Switch to - demo@starbucks-dev-sandbox.com
  • Inside Right panel, navigate to the tabs sections and check that the focus border is visible on the tabs.
Screenshot 2025-01-13 at 1 36 59 PM

Copy link

codesandbox-ci bot commented Dec 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ykelkar-eightfold
Copy link
Contributor

needs_sandbox

@sravichandran-eightfold sravichandran-eightfold merged commit 41039f5 into EightfoldAI:main Jan 8, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants