fix: eng-120721 : added role to date picker span tag #924
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
src/components/DateTimePicker/DatePicker/Generate/generateRangePicker.tsx
Outdated
Show resolved
Hide resolved
sravichandran-eightfold
approved these changes
Jan 14, 2025
sravichandran-eightfold
merged commit 3a05bbb
into
EightfoldAI:main
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
The tool Accessibility Insights for web reports an issue ARIA attributes prohibited for element without any role.
Here the aria-label was used without any role as this is a non tabable element removed aria-label from the span element
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-120721
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Search for DateTimePicker component -> check for RangePicker component -> check for separator arrow role
on route : /events/edit?plannedEventId=xaoNqQjGk0Z
The Date picker arrow under Date and TIme edit section does not report an issue on ARC tool