Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add onerror to avatar component #926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add onerror to avatar component #926

wants to merge 2 commits into from

Conversation

schakka-eightfold
Copy link
Contributor

@schakka-eightfold schakka-eightfold commented Dec 19, 2024 •
edited
Loading

SUMMARY:

Add onError prop to avatar component

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-122634

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • Verify that when an image URL is broken on the profile page, a fallback image is shown instead of the broken image.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ychhabra-eightfold ychhabra-eightfold Awaiting requested review from ychhabra-eightfold

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schakka-eightfold