Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Added aria hidden to expandable button #929

Conversation

rmotwani-c-eightfold
Copy link
Contributor

@rmotwani-c-eightfold rmotwani-c-eightfold commented Dec 30, 2024

SUMMARY:

  • Added aria-hidden=true to select expandable button as it was not passing aria attribute not allowed check from Accessibility insights tool.
  • The button was already out of tab order and with role presentation.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

Jira task - https://eightfoldai.atlassian.net/browse/ENG-122358

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • Go to careers/apply?pid=1970359196742680&domain=microsoft-ta2-dev-sandbox.com
  • Login using: rmotwani-c+1@eightfold.ai
  • Pass: Microsoft@123
  • Run Accessibility insights tool and check if there are no aria-allowed-role error on all the dropdown expand buttons or any element on the page.
  • Check screenshots for reference.

Below ss shows the error on the expand and collapse buttons from select input.
Screenshot 2024-12-30 at 2 45 26 PM

The type of elements marked in the below SS are the ones to verify.
Note there are many such elements on the screen.
Screenshot 2025-01-13 at 12 52 36 PM

Copy link

codesandbox-ci bot commented Dec 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@cpatil-c-eightfold cpatil-c-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sravichandran-eightfold sravichandran-eightfold merged commit 3b15045 into EightfoldAI:main Jan 8, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants