a11y: Added aria hidden to expandable button #929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
aria-hidden=true
to select expandable button as it was not passing aria attribute not allowed check from Accessibility insights tool.GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
Jira task - https://eightfoldai.atlassian.net/browse/ENG-122358
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
aria-allowed-role
error on all the dropdown expand buttons or any element on the page.Below ss shows the error on the expand and collapse buttons from select input.
The type of elements marked in the below SS are the ones to verify.
Note there are many such elements on the screen.