Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menuitem: added containerRole prop to menu item components #931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sthakur-c-2-eightfold
Copy link
Contributor

SUMMARY:

Adds containerRole support to Menu Items to improve semantic structure and accessibility:

  • Adds containerRole prop to MenuItemButton, MenuItemLink, MenuItemCustom, and MenuItemSubHeader components
  • Enables custom role assignment for menu item container elements
  • Improves semantic structure of menu items for better accessibility
  • Maintains consistency across different menu item types

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-99021

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. Verify containerRole prop is properly applied to all menu item types
  2. Test different role values for menu item containers
  3. Check ARIA attributes and roles are correctly rendered
  4. Verify existing menu functionality remains intact
Screenshot 2025-01-07 at 4 12 48 PM

Copy link

codesandbox-ci bot commented Jan 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant