draft: reproduce issue #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eileen-Yu
force-pushed
the
draft/reproduce-issue
branch
from
46d60f1
to
5c76146
Compare
Eileen-Yu
force-pushed
the
feat/ep-with-PROJECT
branch
from
b8edf55
to
369576a
Compare
Eileen-Yu
force-pushed
the
draft/reproduce-issue
branch
from
5c76146
to
369576a
Compare
Eileen-Yu
commented
Aug 31, 2023
| @@ -37,7 +40,7 @@ type PluginRequest struct { | |||
| Universe map[string]string `json:"universe"` | |||
|
|
|||
| // Config stores the project configuration file. | |||
| Config string `json:"config"` | |||
| Config v3.Cfg `json:"config"` | |||
There was a problem hiding this comment.
This is where the v3/cfg is used for the config definition.
Eileen-Yu
commented
Aug 31, 2023
| @@ -52,13 +56,26 @@ func (p *createAPISubcommand) BindFlags(fs *pflag.FlagSet) { | |||
| } | |||
|
|
|||
| func (p *createAPISubcommand) Scaffold(fs machinery.Filesystem) error { | |||
| configBytes, err := yaml.Marshal(p.config) | |||
There was a problem hiding this comment.
The marshalling would fail as p.config does not respect v3/cfg.
Eileen-Yu
force-pushed
the
feat/ep-with-PROJECT
branch
from
9c2f795
to
924daa7
Compare
Eileen-Yu
force-pushed
the
feat/ep-with-PROJECT
branch
2 times, most recently
from
a0ba688
to
65ae4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a draft PR only to reproduce the issue I met when trying to switch
cfgfromstringtov3/cfggo struct.This main problem is the default definition in
v3/cfgfor version is a Version struct.This would cause error when marshalling / unmarshalling as it would be :