Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests don't complete with 3.12 #12

Closed
daveisfera opened this issue Jan 17, 2024 · 2 comments
Closed

Tests don't complete with 3.12 #12

daveisfera opened this issue Jan 17, 2024 · 2 comments

Comments

@daveisfera
Copy link
Contributor

daveisfera commented Jan 17, 2024 •
edited
Loading

It appears that this change in the behavior of 3.12 is causing problems. My understanding of asyncio is limited, but it appears that the reader and/or writer need to be closed so wait_for_closed will complete and that's causing the tests to timeout
daveisfera added a commit to daveisfera/pyrtmp that referenced this issue Jan 17, 2024
@daveisfera
Explicitly close writer so waiting will work properly (fixes Eittipat#12
3ccf5ef 
)
@Eittipat
Copy link
Owner

Eittipat commented Jan 17, 2024 •
edited
Loading

Thank you, I've never been tested in python 12 before

I see you have a patch daveisfera@3ccf5ef
Can you apply this fixes in pull request?

@daveisfera
Copy link
Contributor Author

I was able to figure out the fix and added it to #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eittipat @daveisfera