feat: use Vite 3 as the default #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since vitejs/vite#8768 Vite will now add style assets to the manifest preserving the original extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request leverages improvements in Vite 3 such as vitejs/vite#6649 and vitejs/vite#8768 to simplify the internals of
vite-plugin-ruby.vite-plugin-ruby@3.1.0-beta.0vite_ruby@3.2.0.beta0Background 📜
These changes are not strictly required from a compatibility perspective, as Vite 3 is compatible with previous versions of
vite_rubyandvite-plugin-rubyafter the fixes in vitejs/vite#8768.However, targeting the latest Vite major simplifies the maintenance effort required in Vite Ruby.