WIP: DBAL4 and ORM3 support #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should look into this now and plan what to do since ORM3 and DBAL4 is now out and in real use. Due to the underlying changes we cannot have one major version work with both. I propose to make new version 3.0 which will target ORM3 and DBAL4 and keep 2.x for ORM2 and DBAL3. |
|
Thanks for notifying. Considering the few changes in this PR about doctrine, do you really think it'll require much more efforts to maintain both versions support in 2.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reflects some DBAL changes in version 4.0
We will likely have to create new major version, as there is no way to keep in one version support for both DBAL3 and DBAL4.
For this purpose I have dropped Symfony 5.x support. Symfony 5.x and DBAL3 should be maintained in 2.x branch
WORK IN PROGRESS