[Pipeline] #1245170 - Prevent empty pipeline

opensearch-project/OpenSearch#15032
Elastic-Suite · Sep 19, 2024 · 62ea5f7 · 62ea5f7
1 parent 092cc71
commit 62ea5f7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/Index/Service/IndexSettings.php b/src/Index/Service/IndexSettings.php
@@ -433,9 +433,11 @@ public function getDynamicIndexSettings(Metadata $metadata, LocalizedCatalog|int
         $complexeSourceField = $this->sourceFieldRepository->getComplexeFields($metadata);
         $settings += ['mapping.nested_fields.limit' => \count($complexeSourceField)];
 
-        // Add default pipeline
+        // Add default pipeline if any processor are defined.
         $pipeline = $this->pipelineRepository->createByMetadata($metadata);
-        $settings['default_pipeline'] = $pipeline->getName();
+        if ($pipeline) {
+            $settings['default_pipeline'] = $pipeline->getName();
+        }
 
         return $settings;
     }

diff --git a/src/Search/Repository/Ingest/PipelineRepository.php b/src/Search/Repository/Ingest/PipelineRepository.php
@@ -63,7 +63,7 @@ public function get(string $name): ?IngestPipeline
     /**
      * @throws \Exception
      */
-    public function createByMetadata(Metadata $metadata): IngestPipeline
+    public function createByMetadata(Metadata $metadata): ?IngestPipeline
     {
         $pipelineName = $this->pipelinePrefix . $metadata->getEntity();
         $processors = [];
@@ -72,6 +72,8 @@ public function createByMetadata(Metadata $metadata): IngestPipeline
             $processors = array_merge($processors, $processorsProvider->getProcessors($metadata));
         }
 
-        return $this->create($pipelineName, $pipelineName, $processors);
+        return empty($processors)
+            ? null
+            : $this->create($pipelineName, $pipelineName, $processors);
     }
 }
diff --git a/src/Search/Repository/Ingest/PipelineRepositoryInterface.php b/src/Search/Repository/Ingest/PipelineRepositoryInterface.php
@@ -37,5 +37,5 @@ public function get(string $name): ?IngestPipeline;
      *
      * @param Metadata $metadata metadata
      */
-    public function createByMetadata(Metadata $metadata): IngestPipeline;
+    public function createByMetadata(Metadata $metadata): ?IngestPipeline;
 }