Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable configuration keys #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cmygeHm
Copy link

@cmygeHm cmygeHm commented Apr 19, 2021

  1. It's not so useful to initialize client with string configuration keys, as your examples:
    $configuration = new \ElasticEmailClient\ApiConfiguration([
        'apiUrl' => 'https://api.elasticemail.com/v2/',
        'apiKey' => 'yourApiKey'
    ]);

More useful:

    $configuration = new \ElasticEmailClient\ApiConfiguration([
        \ElasticEmailClient\ApiConfiguration::API_URL => 'https://api.elasticemail.com/v2/',
        \ElasticEmailClient\ApiConfiguration::API_KEY => 'yourApiKey'
    ]);
  1. I think it is better to pass this options via setters and not to do them as required arguments of constructor:
$config = new ApiConfiguration();
$config
            ->setApiUrl($apiUrl)
            ->setApiKey($api);

If you do not agree with me I can remove this commit 478eb73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant